Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46727 )
Change subject: azalia: Treat all negative return values as errors
......................................................................
Patch Set 11: Code-Review+2
Patch Set 11:
Patch Set 11:
Why not make azalia code return >1 values for errors and return 0 for success, so checks can be done like if(!whatever())?
I just wanted to uniformize the checks across all Azalia implementations, since soc/intel/broadwell uses the soc/intel/common implementation. Ideally, we would only have one copy of this code. Ideally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43ce72a01c07eff62d645db28c09584b386532ff
Gerrit-Change-Number: 46727
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 10:20:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment