Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede...
PS2, Line 76: register "PcieRpEnable[3]" = "1"
This has to be PcieRpEnable[8] instead. The internal and external PCIe mapping are documented in Chapter 14 PCI Express* Port / Controller Mapping section EDS vol1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bb8e57cdb688bc544929c94af380b9ef1d936a2
Gerrit-Change-Number: 39115
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 25 Feb 2020 15:58:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment