Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38992 )
Change subject: soc/intel/icelake: Avoid redundant if condition ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... PS3, Line 104: /* Set CdClock Frequency */
Put the comment behind the line? In this case, I’d even remove the comment, as it’s clear from the v […]
Ack
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... PS3, Line 109: disable
disabled
Ack
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... PS3, Line 109: disable
disabled
Ack
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... PS3, Line 111: params->PeiGraphicsPeimInit = 0;
If one branch in the if statement uses {}, all branches need to use it.
Ack
https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p... PS3, Line 111: params->PeiGraphicsPeimInit = 0;
If one branch in the if statement uses {}, all branches need to use it.
Ack