Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, HAOUAS Elyes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50527 )
Change subject: soc/amd: Remove unused <console/console.h>
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Patchset:
PS1:
soc/amd is currently under heavy development, so i'd prefer that no unused headers get removed for now, since that might cause breakage when patches that actually use the include get merged, but the include got removed
File src/soc/amd/cezanne/cpu.c:
https://review.coreboot.org/c/coreboot/+/50527/comment/9c94ffbb_52cc2eaa
PS1, Line 3: #include <console/console.h>
will be used in https://review.coreboot.org/c/coreboot/+/50505/1/src/soc/amd/cezanne/cpu.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84cea1a15d1fb220cf95d7ce469728bc6e299685
Gerrit-Change-Number: 50527
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 11 Feb 2021 12:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment