Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31344 )
Change subject: siemens/mc_apl4: Enable HW SPI TPM on mainboard mc_apl4
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31344/1/src/mainboard/siemens/mc_apl1/varian...
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb:
https://review.coreboot.org/#/c/31344/1/src/mainboard/siemens/mc_apl1/varian...
PS1, Line 109: LPC
i think one comment at the beginning is enough
https://review.coreboot.org/#/c/31344/1/src/mainboard/siemens/mc_apl1/varian...
PS1, Line 113:
only one line at the end of this file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9af7e1a8623302eca46f5ecd8e498678ccda92ad
Gerrit-Change-Number: 31344
Gerrit-PatchSet: 1
Gerrit-Owner: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Feb 2019 13:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment