[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: add framework to search VPD in romstage

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )

Change subject: drivers/vpd: add framework to search VPD in romstage
......................................................................

Patch Set 20:

(2 comments)

Thanks Hung-Te for the feedbacks!
I am resolving the discussions, and made a change per your great comment.

https://review.coreboot.org/c/coreboot/+/34634/15/src/drivers/vpd/vpd.h 
File src/drivers/vpd/vpd.h:

https://review.coreboot.org/c/coreboot/+/34634/15/src/drivers/vpd/vpd.h@26 
PS15, Line 26: extern struct vpd_blob g_vpd_blob;
             : 
             : /*
             :  * This function loads g_vpd_blob CAR_GLOBAL variable.
             :  * The variable is initialized if it was not.
             :  */
             : const struct vpd_blob *vpd_load_blob(void);
             : 
             : /*
             :  * This function gets the base address and size of
             :  * buffers for RO_VPD/RW_VPD binary blobs, and sets
             :  * the struct.
             :  */
             : void vpd_get_buffers(struct vpd_blob *blob);
> Hi Hung-Te, thanks for your review! […]

Done

https://review.coreboot.org/c/coreboot/+/34634/15/src/drivers/vpd/vpd_cbmem.... 
File src/drivers/vpd/vpd_cbmem.c:

https://review.coreboot.org/c/coreboot/+/34634/15/src/drivers/vpd/vpd_cbmem.... 
PS15, Line 83: blob
> There is no need because initialized field is not necessary for the blob variable in stack. […]

Done