Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25464 )
Change subject: coreboot_tables: pass the early_mmc_wake_hw status to payload
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25464/29/payloads/libpayload/includ...
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/25464/29/payloads/libpayload/includ...
PS29, Line 299: Jedec Standard JESD83-B1
are you sure ? […]
do you mean this document is old and can't find it? I see it in newer JESD84-B51 (5.1 spec) as well.
This is what I was referring to "The busy bit in the CMD1 response can be used by a device to tell the host that it is still working on its power-up/reset procedure (e.g., downloading the register information from memory field) and is not ready yet for communication. In this case the host must repeat CMD1 until the busy bit is cleared."
So instead of payload sending: CMD0 -> CMD1 -> CMD1 ... ->CMD1
This patch allows coreboot to send CMD0. Payload will send only CMD1s until device it ready.
This saves time since by the time we are in payload, device is ready or closer to being ready.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4c57d05433c3966118c3642913d7017958cce55
Gerrit-Change-Number: 25464
Gerrit-PatchSet: 29
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 02 Jan 2020 18:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment