Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32984 )
Change subject: util/superiotool: Add AST2400
......................................................................
Patch Set 4:
detect_ast_superio() detects about every chip without a conf-mode
sequence as AST. And maybe more. Having a non-ff value between
0x20 and 0x30 is really nothing AST specific.
Can we move this behind a command-line switch? at least until
somebody figured a more distinctive probing method out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86af69c6b2ccefe2c88eef875bc858239df834f1
Gerrit-Change-Number: 32984
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 01 Mar 2020 16:50:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment