15 Aug
2019
15 Aug
'19
9:15 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33166 )
Change subject: mediatek/mt8183: Use GPIO based CS for SPI0 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33166/2/src/soc/mediatek/mt8183/spi... File src/soc/mediatek/mt8183/spi.c:
https://review.coreboot.org/c/coreboot/+/33166/2/src/soc/mediatek/mt8183/spi... PS2, Line 58: {PAD_SPI_CSB_ID, 0},
as your commit description described, this is actually a per-board logic and should not be hard-code […]
hungte: This is no longer an issue, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4248b3f146a1f1b44124f7a2671dbbc824eda01
Gerrit-Change-Number: 33166
Gerrit-PatchSet: 2
Gerrit-Owner: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 15 Aug 2019 07:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment