[coreboot-gerrit] [S] Change in coreboot[main]: lib: Add Kconfig variable for fw_config default value

[Cliff Huang (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Julius Werner, Paul Menzel, Subrata Banik, Wonkyu Kim.

Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )

Change subject: lib: Add Kconfig variable for fw_config default value
......................................................................

Patch Set 4:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83153/comment/ba295a49_9997ba8c?usp... :
PS3, Line 7: src/lib
> Just `lib/`?

Acknowledged

https://review.coreboot.org/c/coreboot/+/83153/comment/83071754_0a48a67a?usp... :
PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to
> Please start by describing the problem, you are trying to solve.

Acknowledged

https://review.coreboot.org/c/coreboot/+/83153/comment/4832f795_09656ad3?usp... :
PS3, Line 9: is default to
> defaults to

Acknowledged

https://review.coreboot.org/c/coreboot/+/83153/comment/5ac27360_8909b1c5?usp... :
PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to
           : UNDEFINED_FW_CONFIG and won't be used when retrieving fw_config
           : value. Set this with different value in config.<board> file, and
           : it will be used when fw_config is not able to read via Chrome EC,
           : CBFS or VPD.
> Please try to use 72 characters per line.

Acknowledged

File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/83153/comment/0649f0ac_3e9dd038?usp... :
PS3, Line 550: when not able to retrieve
> This reads strangely. […]

Acknowledged