Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33548 )
Change subject: sb/intel/bd82x6x: Set up io_gen_dec in romstage based on devicetree ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-2
This patch depends on the next, while the next depends on this one.
Please use 3 commits to not introduce a temporary regression:
- Duplicate settings to devicetree
- Use devicetree settings and romstage code
- Remove duplicated romstage code
With those three I'm happy to give +2 instead.
What regression would be introduced with this patch? Some IO decode ranges that were only active during the romstage are now active permanently?