Attention is currently required from: Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78293?usp=email )
Change subject: sb/intel/bd82x6x/pcie: Use defines
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/78293/comment/71b4ee57_2d638b6e :
PS1, Line 135: reg32 |= (1 << 17);
Would this be cleaner as ```4 << 15``` and ```2 << 15``` below?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78293?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8fc7cc863017da07dd3ed37b487dae18de92b18
Gerrit-Change-Number: 78293
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 06:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment