Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47506 )
Change subject: soc/intel/jasperlake: Enable VT-d and generate DMAR Table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47506/1/src/soc/intel/jasperlake/ro...
File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47506/1/src/soc/intel/jasperlake/ro...
PS1, Line 85: m_cfg->VtdIopEnable = 0x1;
Don't we need to configure VtdBaseAddress[2] when this is enabled? I see references to it in FSP codebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a9f2df185002a4e58eaa910f867acd0b97ec2b
Gerrit-Change-Number: 47506
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Nov 2020 18:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment