Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38491 )
Change subject: mainboard/hatch: Fix GPE wake comments ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38491/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38491/2/src/mainboard/google/hatch/... PS2, Line 59: confusingly, as : * GPE_LAN_WAK Why do you say confusingly? EC_PCH_WAKE_ODL is routed to GPD2/LAN_WAKE# on the PCH as you said. This is done intentionally for a few reasons: --> This is a special pin which can be used to wake even from deep sleep states. --> WAKE# pin doesn't really work for wake from S0ix and so starting with KBL we switched to using LAN_WAKE# instead for routing the EC wake line.