Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31317 )
Change subject: google/kahlee: No need to guard with HAVE_ACPI_RESUME
......................................................................
Patch Set 1: -Code-Review
Patch Set 1:
Richard, you most likely want to check with Martin or Marshall for my background around AGESA and S3 before commenting further...
I'm still not comfortable on playing with S3. I agree that if ASL code does not advertise S3 then you are probably correct removing these. But it'll add unneeded extra code when S3 is disabled. At least add the message requested by Paul.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8748ccddc8e31569c58deba5d08c98a04326fa8
Gerrit-Change-Number: 31317
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 15:39:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment