Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Angel Pons, Patrick Rudolph.
Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61015 )
Change subject: soc/intel/denverton_ns: enable Denverton to use common systemagent code
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/denverton_ns/systemagent.c:
https://review.coreboot.org/c/coreboot/+/61015/comment/c9aa8a86_d5ed3b30
PS10, Line 68: BGSM
Weird that DNV-NS has BGSM but doesn't have an iGPU.
indeed, but sometimes that's just the Intel Way, because of how they share IP across different Si families. Easier to leave some functionality in and be disabled by a BIOS setting than to try and remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39df1f0889c1c4ac6f2b3c25ccb7817e4492f446
Gerrit-Change-Number: 61015
Gerrit-PatchSet: 10
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 11:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment