[coreboot-gerrit] Change in coreboot[master]: southbridge/amd: deduplicate MMIO macro [WIP]

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )

Change subject: southbridge/amd: deduplicate MMIO macro [WIP]
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... 
File src/mainboard/asus/f2a85-m/bootblock.c:

https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... 
PS1, Line 35: 	SB_MMIO_MISC32(0x28) = reg32;
> Looks like <amdblocks/acpimmio.h> misc_read/write32(). […]

Right. The macro indeed seems to be a candidate for removal.

These files should be touched too: md/bettong/boardid.c amd/lamar/romstage.c asus/f2a85-m/bootblock.c msi/ms7721/bootblock.c