29 Mar
2020
29 Mar
'20
9:10 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39903 )
Change subject: asus/p2b-d: Transform into variant ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39903/2/src/mainboard/asus/p2b/Kcon... File src/mainboard/asus/p2b/Kconfig:
https://review.coreboot.org/c/coreboot/+/39903/2/src/mainboard/asus/p2b/Kcon... PS2, Line 16: BASE
nit: BASE looks too similar to BOARD :S
Maybe call it HAS_TWO_CPU_SLOTS ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1161c726c8c752b5b1e152e1617811989631096e
Gerrit-Change-Number: 39903
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Mar 2020 19:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment