Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: src/arch/x86: Use core apic id to get cpu_index()
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/#/c/26346/15//COMMIT_MSG
Commit Message:
PS15:
Please reduce to 72 chars per line and add full stops.
Done
https://review.coreboot.org/#/c/26346/15//COMMIT_MSG@11
PS15, Line 11: not true incase
*not be true in case*
Done
https://review.coreboot.org/#/c/26346/15/src/arch/x86/cpu.c
File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/26346/15/src/arch/x86/cpu.c@340
PS15, Line 340:
Maybe leave a comment here, why we can't use `cpu_info`. i.e. short version […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350
Gerrit-Change-Number: 26346
Gerrit-PatchSet: 15
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 10 May 2019 14:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment