Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73695 )
Change subject: soc/intel/meteorlake: Send EOP in parallel ......................................................................
Patch Set 5:
(3 comments)
This change is ready for review.
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/73695/comment/9ee2d315_c86274fe PS3, Line 238: do_send_end_of_post
just call into cse_eop_helper()
Ack
https://review.coreboot.org/c/coreboot/+/73695/comment/b85f6c3b_9cea31f3 PS3, Line 283: : static void send_cse_eop_with_late_finalize(void *unused) :
Ack. Thanks for reviewing in detail.
https://review.coreboot.org/c/coreboot/+/73695/comment/4080d106_15910f50 PS3, Line 293: (CONFIG(SOC_INTEL_CSE_SEND_EOP_EARLY) && CONFIG(SOC_INTEL_CSE_SEND_EOP_PARALLELLY)))
why you have combined EOP early with running in parallel ?
If EOP early is running in parallel then we have to run cse_finalize late.
It seems redundant though. I will remove it.