Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: soc/mediatek/mt8183: Use cached calibration result for faster bootup ......................................................................
Patch Set 38:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35164/38/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/38/src/soc/mediatek/mt8183/dr... PS38, Line 1988: } else { nit: I wonder if we should move the else-block to another static function to make it clear, but it's also fine in current shape.
https://review.coreboot.org/c/coreboot/+/35164/38/src/soc/mediatek/mt8183/dr... PS38, Line 2013: assert(sum != 0); nit: since sum is not changed during dramc_engine2_end, we should probably do assert immediately after for-loop is done.