2 comments:
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
Patch Set #38, Line 1988: } else {
nit: I wonder if we should move the else-block to another static function to make it clear, but it's also fine in current shape.
Patch Set #38, Line 2013: assert(sum != 0);
nit: since sum is not changed during dramc_engine2_end, we should probably do assert immediately after for-loop is done.
To view, visit change 35164. To unsubscribe, or for help writing mail filters, visit settings.