Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )
Change subject: soc/intel/tgl: Disable hybrid storage mode in recovery mode ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@9 PS2, Line 9: CSE
I see CSE and CSME being used interchangeably. […]
oh I thought I changed all to CSME but missed this. Thanks for pointing this out.
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@9 PS2, Line 9: WA
This is Washington! 😄 […]
Thanks for information! I will update this accordingly.
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@16 PS2, Line 16: Cq-Depend: chrome-internal:3100721
This tag doesn't mean anything upstream (unlike Chromium Gerrit, we don't have a CQ bot)
do I need to remove this? I wanted to mention this has a dependency on chrome-internal:3100721, and is there any other way to do it?
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... PS2, Line 259: the fix
about the fix: is it something that needs to be changed in the CSME Lite SKU firmware?
the final fix is still in discussion, so it is not decided yet.
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... PS2, Line 259: WA
W/A
Ack