[coreboot-gerrit] Change in coreboot[master]: /amd/fsp/picasso Fix type 17 smbios misalignment

[Jason Glenesk (Code Review)]

Hello Jason Glenesk,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/44086

to review the following change.

Change subject: /amd/fsp/picasso Fix type 17 smbios misalignment
......................................................................

/amd/fsp/picasso Fix type 17 smbios misalignment

Add __packed to TYPE17_DMI_INFO structure to remove padding. Remove
reserved fields that are no longer required. Corresponding change will
also be made within fsp to pack the structure.

BUG=b:154046847
TEST=Boot a trembyle with and without the reserved fields and confirm
type 17 table is unchanged.

Change-Id: I9ba7e2a4fb82c7b0b77ee7c6c075e6211d4f6adf
Signed-off-by: Jason Glenesk 
---
M src/vendorcode/amd/fsp/picasso/dmi_info.h
1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/44086/1

diff --git a/src/vendorcode/amd/fsp/picasso/dmi_info.h b/src/vendorcode/amd/fsp/picasso/dmi_info.h
index adab2f9..36ca719 100644
--- a/src/vendorcode/amd/fsp/picasso/dmi_info.h
+++ b/src/vendorcode/amd/fsp/picasso/dmi_info.h
@@ -178,7 +178,6 @@
   OUT DMI_T17_MEMORY_TYPE       MemoryType;             ///< The type of memory used in this device.
   OUT DMI_T17_TYPE_DETAIL       TypeDetail;             ///< Additional detail on the memory device type
   OUT UINT16                    Speed;                  ///< Identifies the speed of the device, in megahertz (MHz).
-  OUT UINT32                    _Reserved1_;
   OUT UINT64                    ManufacturerIdCode;     ///< Manufacturer ID code.
   OUT CHAR8                     SerialNumber[9];        ///< Serial Number.
   OUT CHAR8                     PartNumber[21];         ///< Part Number.
@@ -188,8 +187,7 @@
   OUT UINT16                    MinimumVoltage;         ///< Minimum operating voltage for this device, in millivolts
   OUT UINT16                    MaximumVoltage;         ///< Maximum operating voltage for this device, in millivolts
   OUT UINT16                    ConfiguredVoltage;      ///< Configured voltage for this device, in millivolts
-  OUT UINT32                    _Reserved2_;
-} TYPE17_DMI_INFO;
+}__packed  TYPE17_DMI_INFO;

/// Collection of pointers to the DMI records
 typedef struct {