Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46769 )
Change subject: mb/google/auron: Add SATA PCI device to overridetree
......................................................................
Patch Set 2:
Patch Set 1: Code-Review-2
Patch Set 1:
I'm confused... if you remove the 1f.2 from the `devicetree.cb` how
can sconfig match the chips of that and the `override.cb`. Did you
check all variants? In particular one that has only 1f.2 below the
chip?
D'oh, no wonder why sconfig would be unable to override anything, then.
Now it works as intended. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46769
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I013dbe1403567b93c8ee0e66f76481f2a3f42796
Gerrit-Change-Number: 46769
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 27 Oct 2020 11:15:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment