Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib ......................................................................
Patch Set 9:
(5 comments)
File payloads/libpayload/include/arm64/arch/io.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120312): https://review.coreboot.org/c/coreboot/+/53903/comment/d3465059_a5cd86a5 PS9, Line 154: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120312): https://review.coreboot.org/c/coreboot/+/53903/comment/6b1c9bb2_085e77e4 PS9, Line 159: } void function return statements are not generally useful
File src/commonlib/include/commonlib/coreboot_tables.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120312): https://review.coreboot.org/c/coreboot/+/53903/comment/b287abf1_1fedeac0 PS9, Line 332: uint32_t tag; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120312): https://review.coreboot.org/c/coreboot/+/53903/comment/f257f4f3_606c2adf PS9, Line 333: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120312): https://review.coreboot.org/c/coreboot/+/53903/comment/db5c55b4_d366cbb1 PS9, Line 334: void *config_base; please, no spaces at the start of a line