Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46112 )
Change subject: soc/amd/picasso: Refactor transfer buffer check
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46112/2/src/soc/amd/picasso/bootblo...
File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46112/2/src/soc/amd/picasso/bootblo...
PS2, Line 130: if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) {
braces {} are not necessary for single statement blocks
This is the only thing I see.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf46f8edb6b70c63f623522e2bcd2f22d6d4790b
Gerrit-Change-Number: 46112
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Oct 2020 00:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment