Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig
......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35799/5/src/mainboard/intel/glkrvp/...
File src/mainboard/intel/glkrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/35799/5/src/mainboard/intel/glkrvp/...
PS5, Line 89: config SOC_INTEL_COMMON_BLOCK_SGX_ENABLE
: bool
: default y
Sorry, I don't get what you mean. sgx was enabled in the devicetree (yes, mb specific) before. now it gets enabled via the new Kconfig setting in the boards Kconfig (the mb specific one).
I don't want to change the default behaviour as I don't know if SGX is working on all other boards.
Not sure what my train of thought was here. Is enabling SGX something that should be done by default on this platform or not? anyway... go ahead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f08e85898304bba6680075ca5d6bce26aef9a4d
Gerrit-Change-Number: 35799
Gerrit-PatchSet: 33
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 18:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment