Attention is currently required from: Nicholas Chin.
Matt DeVillier has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84344?usp=email )
Change subject: soc/xilinx/zynq7000: Add UART driver
......................................................................
Patch Set 1:
(1 comment)
File src/soc/xilinx/zynq7000/uart.c:
https://review.coreboot.org/c/coreboot/+/84344/comment/db765e72_dcfa9cae?usp... :
PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Would it make sense to put this under src/drivers/uart as a common xilinx driver? […]
thoughts @nic.c3.14@gmail.com? If you want to do in a follow-up that's fine, just ack and we can merge as-is
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84344?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b845af3f057847d7c5c56615396f946df39b921
Gerrit-Change-Number: 84344
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: coreboot org
coreboot.org@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 23 Jan 2025 00:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org
coreboot.org@gmail.com