Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32263 )
Change subject: google/kukui: Include panel identifier (LCM ID) into SKU ID
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32263/2/src/mainboard/google/kukui/boardid.c
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32263/2/src/mainboard/google/kukui/boardid.c...
PS2, Line 95: get_index(2, &lcm);
When we reads this pin on early Kukui boards, what kind of result do we expect? […]
According to Ayo, at least Rev2 will return 0.
And I think we can get rid of Rev0/1 since it'll be handled in earlier if-case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c00bc8ce3c71c445c5c4561403ce8ef4dd5844
Gerrit-Change-Number: 32263
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 01:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Gerrit-MessageType: comment