Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )
Change subject: inteltool: Move GPIOs to c files per platform ......................................................................
Patch Set 48:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31504/48/util/inteltool/platform.h File util/inteltool/platform.h:
https://review.coreboot.org/c/coreboot/+/31504/48/util/inteltool/platform.h@... PS48, Line 23: size_t apl_communities_count; Why aren't these `extern const`, too?
https://review.coreboot.org/c/coreboot/+/31504/47/util/inteltool/platform_su... File util/inteltool/platform_sunrisepoint_common.h:
https://review.coreboot.org/c/coreboot/+/31504/47/util/inteltool/platform_su... PS47, Line 23: extern Why omit the `extern`? (I only just learned, that one can.)