Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35887 )
Change subject: soc/intel/common/block/sa: Add compiletime error on undefined SA_PCIE_LENGTH
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35887/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/35887/1/src/soc/intel/common/block/...
PS1, Line 31: #endif
A Static_assert() might look nicer. but that's a matter of taste, I guess?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9facecc4caa869e65f938a55508741dd48b09b0
Gerrit-Change-Number: 35887
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 08 Oct 2019 12:58:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment