Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, TangYiwei, Varshit Pandya.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )
Change subject: mb/intel/avenuecity_crb: Add GNR/SRF-AP 2S server board Avenue City ......................................................................
Patch Set 51:
(3 comments)
File src/drivers/ocp/include/vpd.h:
https://review.coreboot.org/c/coreboot/+/81319/comment/429f0eac_1b60e62e : PS50, Line 6: #include <include/types.h>
Huh? This header doesn't need `types. […]
This is because this header defines some functions that use the types, e.g.,
int get_int_from_vpd_range(const char *const key, const int fallback, const int min, const int max);
If we do not include the <include/types.h> inside this file, we need to include <include/types.h> ahead of this file <drivers/ocp/include/vpd.h> in the file uses these logics. However, put <include/types.h> ahead of <driver/..../vpd.h> conflicts with alphabetical order and not straightforward in usage.
Hence we still need the change here ...
File src/mainboard/intel/avenuecity_crb/config/iio.c:
https://review.coreboot.org/c/coreboot/+/81319/comment/2677fe8c_28d33575 : PS36, Line 14: _IIO_PORT_CFG_STRUCT_X8(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x1), : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_DISABLED, : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x2), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x3), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x4), : _IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x5)
If it's just the macros, we could define some macros to use in coreboot that use left-to-right order […]
Good suggestion! I added it into https://review.coreboot.org/c/coreboot/+/81318 and updated the macro reference here as well.
File src/mainboard/intel/avenuecity_crb/config/iio.c:
https://review.coreboot.org/c/coreboot/+/81319/comment/6352d8d3_554a6ec3 : PS50, Line 28: (sizeof(iio_config_table)/sizeof(struct iio_pe_config))
`ARRAY_SIZE(iio_config_table)`
Done