Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31518 )
Change subject: vendorcode/siemens: Save currently open hwi file name
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31518/1/src/vendorcode/siemens/hwilib/hwilib...
File src/vendorcode/siemens/hwilib/hwilib.c:
https://review.coreboot.org/#/c/31518/1/src/vendorcode/siemens/hwilib/hwilib...
PS1, Line 483: *
I think you don't need that for short comments.
Yes, that's true. I need to improve, happens too often lately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id69e0f6c914c2b8e4551fd8a4fb7d452d176afb3
Gerrit-Change-Number: 31518
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 09:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment