Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 83: : /* GPP_B0 - NC/TP */ : PAD_NC(GPP_B0, UP_20K), : : /* GPP_B1 - NC/TP */ : PAD_NC(GPP_B1, UP_20K),
technically doesn't really matter, does it?
I have no idea if they are actually NC.
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 205: /* GPP_D7 - NC */ : PAD_NC(GPP_D7, UP_20K),
nope; R526 is unstuff/nonpop
U40 is missing too.