Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig@...
PS2, Line 118: allocated in CBMEM.
nit: maybe say "in CBMEM from the start and doesn't need to be reserved in memlayout", because all work buffers end up in CBMEM at some point
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80783274179ae7582bbb4c8f9d392895623badce
Gerrit-Change-Number: 38900
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Feb 2020 23:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment