Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43958 )
Change subject: soc/mediatek/mt8192: Add PLL and clock init support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43958/1/src/soc/mediatek/mt8192/pll...
File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/43958/1/src/soc/mediatek/mt8192/pll...
PS1, Line 114: MUX_UPD(TOP_BUS_AXIMEM_SEL, clk_cfg_0, clk_cfg_0_set, clk_cfg_0_clr, 24, 3, clk_cfg_update, 3),
Could you please fix this? […]
BTW, given most calls are MUX_UPD and only very few are MUX, I think one possible change is to drop MUX, rename MUX_UPD to MUX, and then for those old MUX do
MUX(....., NULL, 0)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49342c058577e8e107b7e56c867bf21532e40d2
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 3
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 09:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment