Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email )
Change subject: libpayload: Make GPL commonlib includes available to payloads and tests
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81287/comment/97893252_295527b2 :
PS2, Line 11: so that payloads can also call
: the functions in them directly.
I am confused. Under which circumstances are payloads supposed to include `libpayload.h` and under which circumstances should they include the specific include files?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8
Gerrit-Change-Number: 81287
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 22:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment