10 Dec
2020
10 Dec
'20
1:28 a.m.
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48518 )
Change subject: mb/google/volteer: Assert BT_DISABLE_L (GPP_A13) in early_gpio_table ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48518/1/src/mainboard/google/voltee... PS1, Line 405: GPP_A13
Nick, please read the bug for the background. The intent is to drive 0 and later to drive 1. […]
ah, re-reading this now. I guess, I have to re-do this for each of the gpio.c files. thanks for pointing this out.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48518
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa5799e9cab69c074b7920604c8a6c85ad07358a
Gerrit-Change-Number: 48518
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Levin levinale@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Caveh Jalali caveh@chromium.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 00:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Levin levinale@google.com
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment