Attention is currently required from: Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64008 )
Change subject: mb/google/brya/acpi: Add support for NBCI _DSM subfunction
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/acpi/nbci.asl:
https://review.coreboot.org/c/coreboot/+/64008/comment/6907f65e_369f51d4
PS1, Line 25: (0 << 10) | /* No 3D Hotkeys */
is it like `10` is to represent bit10 and `0` to represent `no`?
likewise other bits like bit 9, bit 7 etc.?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64008
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19eb9417923d297a084d6f5329682e91cd506a9e
Gerrit-Change-Number: 64008
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 23:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment