Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36225 )
Change subject: soc/intel/common: Include Tigerlake device IDs
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36225/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/36225/7/src/soc/intel/common/block/...
PS7, Line 57: #define PAD_CFG0_LOGICAL_RESET_DSW_PWROK (0U << 30)
seems unrelated
https://review.coreboot.org/c/coreboot/+/36225/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc_def.h:
https://review.coreboot.org/c/coreboot/+/36225/7/src/soc/intel/common/block/...
PS7, Line 40: #define LPC_BC_LE (1 << 2) /* LE */
seems unrelated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19047354718bdf510dffee4659d885f1313a751b
Gerrit-Change-Number: 36225
Gerrit-PatchSet: 7
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment