Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: kodama: add a new configuration for Kodama.
......................................................................
Patch Set 2:
Patch Set 2:
Looks like this change does two things: It adds the Kodama variant to google/kukui, and it also adds some display/panel stuff, for all boards. Maybe split this change in two?
Dear Angel,
Yes, I think 1. Kconfig and Kconfig.name have Kodama board configuration, 2. display.h and panel_kodama.c have Kodama relevant panel information and mipi sequence. So as I understood that will runtime insmod panel driver and based on board name.
In addition, I will modify the code.
Thanks and best regards
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e80e800ba041df1dda2b0f84470d1ef58bc946
Gerrit-Change-Number: 33616
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hao He
hao.he@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Jun 2019 00:09:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment