Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi...
File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi...
PS2, Line 37: default 0x4000 if BOOTBLOCK_CONSOLE
Can't we always default to 0x4000? Or is flash space a scarce resource?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9988c77cf9677167a382aa4dc7dcfa2bc4cbe02
Gerrit-Change-Number: 41460
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 17 May 2020 14:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment