5 Apr
2023
5 Apr
'23
9:45 p.m.
Attention is currently required from: Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74241 )
Change subject: mb/starlabs/starbook/adl: Correct the number of NID entries ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74241/comment/4cb52768_ee0fe59e PS1, Line 8:
Please elaborate. What didn’t work? […]
Done
File src/mainboard/starlabs/starbook/variants/adl/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/74241/comment/23f77a6e_b56d6dd3 PS1, Line 57: 10, /* Number of 4 dword sets */
That’s not mentioned in the commit message.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79825313a4801c120a0a2a321cbabab7c728aa71
Gerrit-Change-Number: 74241
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 05 Apr 2023 21:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment