Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: Add Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M. ......................................................................
Patch Set 3:
(2 comments)
Could this be made a variant?
https://review.coreboot.org/#/c/30987/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30987/3//COMMIT_MSG@7 PS3, Line 7: Add Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M. Please use a prefix and a shorter commit message summary. Maybe:
mb/asus: Add Asus A88XM-E FM2+
The other information should go into the commit message body:
The port is based on the Asus F2A85-M. The differences are …
Also add the documentation.
Please also add, how you tested this.
Successfully booted coreboot with SeaBIOS payload 1.12… and then Linux 4.… from the hard drive?
The CPU is AMD … and the RAM ….
https://review.coreboot.org/#/c/30987/3//COMMIT_MSG@9 PS3, Line 9: Signed-off-by: Balazs Vinarz vinibali1@gmail.com Please remove the duplicate line here, and leave the Signed-off-by line below.