Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39976 )
Change subject: mb/siemens/chili: Add new mainboard
......................................................................
Patch Set 39:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39976/38/src/mainboard/siemens/chil...
File src/mainboard/siemens/chili/variants/base/gpio.c:
https://review.coreboot.org/c/coreboot/+/39976/38/src/mainboard/siemens/chil...
PS38, Line 48: /* SPI0_CS1_B GPIO */ PAD_NC(SPI0_CS1_B, NONE),
: /* SPI0_CLK GPIO */ PAD_NC(SPI0_CLK, NONE),
Wrong settings after rebase.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d3508b615ec877edc8db756e9ad38132b37219c
Gerrit-Change-Number: 39976
Gerrit-PatchSet: 39
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Sebastian Witt
seb.witt@googlemail.com
Gerrit-Comment-Date: Mon, 12 Oct 2020 09:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment