Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi... PS3, Line 373: Notify (CREC, 0x80) I wonder if it is better to do the following:
#ifdef EC_ENABLE_PD_MCU_DEVICE Method (_Q1C, 0, NotSerialized) { Store ("EC: USB MUX", Debug) Notify (_SB.PCI0.LPCB.EC0.CREC.ECPD, 0x80) } #endif
This ensures that the Notify() interrupt is routed to the child device (cros-usbpd-notify) instead of the Cros EC LPC parent device.
Note that this too would be a sort of hack, since the ECPD notify should be initiated from the EC, instead of having EC_HOST_EVENT_USB_MUX remapped to the handler for EC_HOST_EVENT_PD_MCU.
https://review.coreboot.org/c/coreboot/+/40024/3/src/ec/google/chromeec/acpi... PS3, Line 369: // USB MUX Interrupt : Method (_Q1C, 0, NotSerialized) : { : Store ("EC: USB MUX", Debug) : Notify (CREC, 0x80) : } I think it's good to investigate what on the Chrome OS kernel is using the EC_HOST_EVENT_USB_MUX interrupt.