Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: Add configurable ramstage support for minimal PCI scanning ......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36221/11/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/36221/11/src/device/pci_device.c@94... PS11, Line 947: dev->enabled = 0;
You probably should never clear dev->enabled in connection with MINIMAL_PCI_SCANNING=y. […]
Ack
https://review.coreboot.org/c/coreboot/+/36221/13/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/36221/13/src/device/pci_device.c@44... PS13, Line 446: pci_bus_read_resources_always(dev);
Let's try to avoid the use of obscure term 'scanning'. […]
Ack