[coreboot-gerrit] [S] Change in coreboot[main]: src/arch/x86/c_start.S: Add proper x86_64 code

[Benjamin Doron (Code Review)]

Attention is currently required from: Angel Pons, Felix Singer, Jérémy Compostella, Martin L Roth, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59874?usp=email )

Change subject: src/arch/x86/c_start.S: Add proper x86_64 code
......................................................................

Patch Set 5:

(1 comment)

File src/arch/x86/c_start.S:

https://review.coreboot.org/c/coreboot/+/59874/comment/0b8427da_07312871 :
PS2, Line 99: 	push_cpu_info
            : 
            : #if CONFIG(CPU_INFO_V2)
            : 	/* Allocate the per_cpu_segment_data on the stack */
            : 	push_per_cpu_segment_data
            : 
            : #if ENV_X86_64
            : 	/*
            : 	 * Update the BSP's per_cpu_segment_descriptor to point to the
            : 	 * per_cpu_segment_data that was allocated on the stack.
            : 	 */
            : 	set_segment_descriptor_base $per_cpu_segment_descriptors, %esp
            : 
            : 	movabs	per_cpu_segment_selector, %rax
            : 	mov	%eax, %gs
            : #else
            : 	/*
            : 	 * Update the BSP's per_cpu_segment_descriptor to point to the
            : 	 * per_cpu_segment_data that was allocated on the stack.
            : 	 */
            : 	set_segment_descriptor_base $per_cpu_segment_descriptors, %esp
            : 
            : 	mov	per_cpu_segment_selector, %eax
            : 	mov	%eax, %gs
            : #endif
> Add a comment about removing all of this in the commit message?

It's only removed compared to a previous version of this patch? It was dropped in the rebase.