Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: Add common API for loading firmwares
......................................................................
Patch Set 21:
Could you suggest the struct naming if mtlib_ prefix removed ?
struct mtlib_mcu *mcu
assuming we have mcu_common.h and common/mcu.c, I'll probably name them
struct mtk_mcu;
int mtk_init_mcu(struct mtk_mcu);
or mt_mcu (I think we already have lots of mtk/mt prefix API and structs)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie94001bbda25fe015f43172e92a1006e059de223
Gerrit-Change-Number: 46930
Gerrit-PatchSet: 21
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Dec 2020 06:20:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment